Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: retry proxy_spec tests that flake #30717

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 5, 2024

Additional details

  • Addressed one test that was flaking because the socket close event was already fired prior to the listener being added
  • Added a retry on the generating certificates tests that appear to be flaky
  • Changed the 9001 port to 2222 so it wouldn't conflict with the locally running services port

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

Copy link

cypress bot commented Dec 5, 2024

cypress    Run #58685

Run Properties:  status check passed Passed #58685  •  git commit 59debd4b21: test: fix proxy spec flake
Project cypress
Branch Review mschile/proxy_spec_flake
Run status status check passed Passed #58685
Run duration 08m 42s
Commit git commit 59debd4b21: test: fix proxy spec flake
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 85
View all changes introduced in this branch ↗︎
UI Coverage  45.31%
  Untested elements 32  
  Tested elements 29  
Accessibility  91.43%
  Failed rules  0 critical   4 serious   0 moderate   0 minor
  Failed elements 89  

@mschile mschile merged commit 02db483 into develop Dec 5, 2024
87 checks passed
@mschile mschile deleted the mschile/proxy_spec_flake branch December 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: address flake in proxy integration tests
2 participants