fix: hang when Network.enable is not implemented for a target #30727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When attaching to a target, we try to call
Network.enable
and thenRuntime.runIfWaitingForDebugger
. However, since both of these calls are in the sametry/catch
, if theNetwork.enable
call throws an error, we never callRuntime.runIfWaitingForDebugger
which causes the target to hang.In order to fix the issue, the two calls are now split into their own
try/catch
blocks.Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?