Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hang when Network.enable is not implemented for a target #30727

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 6, 2024

Additional details

When attaching to a target, we try to call Network.enable and then Runtime.runIfWaitingForDebugger. However, since both of these calls are in the same try/catch, if the Network.enable call throws an error, we never call Runtime.runIfWaitingForDebugger which causes the target to hang.

In order to fix the issue, the two calls are now split into their own try/catch blocks.

Steps to test

How has the user experience changed?

Before:
Screenshot 2024-12-06 at 3 54 19 PM

After:
Screenshot 2024-12-06 at 3 52 54 PM

PR Tasks

Copy link

cypress bot commented Dec 6, 2024

cypress    Run #58751

Run Properties:  status check passed Passed #58751  •  git commit 36aa397723: Update cli/CHANGELOG.md
Project cypress
Branch Review mschile/target_waiting_for_debug_hang
Run status status check passed Passed #58751
Run duration 23m 52s
Commit git commit 36aa397723: Update cli/CHANGELOG.md
Committer Matt Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29400
View all changes introduced in this branch ↗︎
UI Coverage  46.24%
  Untested elements 188  
  Tested elements 166  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 907  

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@mschile mschile requested a review from ryanthemanuel December 9, 2024 16:17
@mschile mschile merged commit e96593b into develop Dec 9, 2024
84 of 85 checks passed
@mschile mschile deleted the mschile/target_waiting_for_debug_hang branch December 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error attaching to target cri p [Error]: 'Network.enable' wasn't found
2 participants