-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed backface visibility. #5591
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
I guess But interestingly, it doesn't work on my local ubuntu with develop branch code. |
@sainthkh what happens if the element has |
@bkucera I'll check it out. |
@bkucera Interestingly, that didn't happen. I created this code pen and tested with Chrome 78 and Firefox 70 on Ubuntu 18.04. I couldn't see "hello transformed world". p.s. server-integration-tests failed because of timeout. |
thanks @sainthkh , I'll rerun CI |
@chrisbreiding Fixed. |
* Handle elements hidden by scale. * Check rotateX(90deg), rotateY(90deg) + Use of getBoundingClientRect * Added reason message. * Fixed typo. Co-Authored-By: Chris Breiding <[email protected]> Update packages/driver/src/dom/visibility.js Co-Authored-By: Chris Breiding <[email protected]> Fixed typo. * Use numberRegex created for backface-visibility. * Added test for reason message. * Added missing message test in #5591
…ress-io#5590) * Handle elements hidden by scale. * Check rotateX(90deg), rotateY(90deg) + Use of getBoundingClientRect * Added reason message. * Fixed typo. Co-Authored-By: Chris Breiding <[email protected]> Update packages/driver/src/dom/visibility.js Co-Authored-By: Chris Breiding <[email protected]> Fixed typo. * Use numberRegex created for backface-visibility. * Added test for reason message. * Added missing message test in cypress-io#5591
User facing changelog
When
backface-visibility: hidden
androtateX(180deg)
,to.be.hidden
is nowtrue
.Additional details
Like card example provided, sometimes we want something to be invisible when it is rotateX(180deg) or rotateY(180deg).
Now, we can check them out.
I just added some tests and related code.
It uses simplified version of backface culling.
How has the user experience changed?
Now we can check backface.
PR Tasks
Has a PR for user-facing changes been opened incypress-documentation
?Have API changes been updated in thetype definitions
?Have new configuration options been added to thecypress.schema.json
?