Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot set property response of undefined #8965

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

sainthkh
Copy link
Contributor

User facing changelog

Fix the flaky "Cannot set property response of undefined".

Additional details

  • Why was this change necessary? => This causes flaky failures.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => This failure happened because request is sometimes undefined. But sendContinueFrame assumes that request is always non-undefined. Fixed this problem.

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated? => How should I test this?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
  • [N/A] Have API changes been updated in the type definitions?
  • [N/A] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 26, 2020

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review October 26, 2020 08:35
@sainthkh sainthkh requested a review from flotwig October 26, 2020 08:35
@flotwig flotwig merged commit a20a9e3 into cypress-io:develop Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set property response of undefined
3 participants