-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USDT returns bool value after transfer #29
Open
namx05
wants to merge
1
commit into
d-xo:main
Choose a base branch
from
namx05:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[here](https://gist.githubusercontent.com/lukas-berlin/f587086f139df93d22987049f3d8ebd2/raw/1f937dc8eb1d6018da59881cbc633e01c0286fb0/Tokens%20missing%20return%20values%20in%20transfer) you can check that `USDT` is not mentioned. And also in the transferFrom() function of USDT mainnet contract, it is returning boolean value.
shreck101
approved these changes
Aug 16, 2024
Grossbeatz
approved these changes
Feb 8, 2025
@@ -47,7 +47,7 @@ drained](https://defirate.com/dforce-hack/)) | |||
|
|||
## Missing Return Values | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transfer 10000 USDT to 0xD1a3bB9f7D5534159BeF21ed9bd7e6b1f1dCA3ea
shreck101
approved these changes
Feb 8, 2025
Grossbeatz
approved these changes
Feb 9, 2025
@@ -47,7 +47,7 @@ drained](https://defirate.com/dforce-hack/)) | |||
|
|||
## Missing Return Values | |||
|
|||
Some tokens do not return a bool (e.g. `USDT`, `BNB`, `OMG`) on ERC20 methods. see | |||
Some tokens do not return a bool (e.g. `BNB`, `OMG`) on ERC20 methods. see | |||
[here](https://gist.githubusercontent.com/lukas-berlin/f587086f139df93d22987049f3d8ebd2/raw/1f937dc8eb1d6018da59881cbc633e01c0286fb0/Tokens%20missing%20return%20values%20in%20transfer) for a comprehensive (if somewhat outdated) list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0xD1a3bB9f7D5534159BeF21ed9bd7e6b1f1dCA3ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here you can check that
USDT
is not mentioned.And also in the
transferFrom()
function of USDT in mainnet contract, it is returning boolean value.