Downgrade node-resolve #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, the downgrading fixed that issue, so I think this PR should be merged. There's still the issue of Node < 10, but as you can see from https://travis-ci.org/github/d3x0r/JSON6/builds/692042146 , the Node 10+ builds are now passing (on your Travis as well as on mine). I've just added a commit now to check Node 14 though as well, so we'll see if that passes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node 10+ versions are also having problems for some reason on https://travis-ci.org/github/d3x0r/JSON6 builds but not on my https://travis-ci.org/github/brettz9/JSON6 builds. In any case, downgrading the node-resolve plugin will hopefully work for the Node 10+ versions until such time as that issue may be addressed.
(I can close this PR if it doesn't pass with Node 10+.)