Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint #330

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Stylelint #330

wants to merge 5 commits into from

Conversation

isidornygren
Copy link

Description

  • Removed lesshint in favour of stylelint
  • Configured prettier to prettify less files (and some others)
  • "Fixed" less files (mostly just adding disable comments)

Copy link
Contributor

@JakeSidSmith JakeSidSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best we go through these changes in person as there's a lot, and a few things I'd like to test.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.create-button-pew();
background-color: @background;
color: @color;

&.link,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh... why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zelda is the only one 4 me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a duplicate, I moved the contents of the block into the other block.

src/less/variables.less Outdated Show resolved Hide resolved
&:hover:not([disabled]):not(.disabled) {
/* stylelint-disable-next-line selector-max-specificity*/
&:hover:not([disabled]),
&:hover:not(.disabled) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I suggested this, but I'm not sure it'll work actually.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imma change it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants