Support Docker mode #63
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| package docker | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "io" | ||
| "math/rand" | ||
| "net" | ||
|
|
||
| //"os" | ||
| "strconv" | ||
|
|
||
| "github.com/docker/docker/api/types" | ||
| "github.com/docker/docker/api/types/container" | ||
| "github.com/docker/docker/client" | ||
| "github.com/docker/go-connections/nat" | ||
|
|
||
| "github.com/dachad/tcpgoon/debugging" | ||
| ) | ||
|
|
||
| type IPandPort struct { | ||
| IP string | ||
| Port int | ||
| } | ||
|
|
||
| func lookForAvailableLocalPort() (availablePort int){ | ||
|
There was a problem hiding this comment. up to you, but i would try the same the docker is exposing, and if that fails, require the user to be the one that chooses one |
||
| minPort := 1025 | ||
| maxPort := 65535 | ||
|
|
||
| for { | ||
| availablePort = rand.Intn(maxPort - minPort) + minPort | ||
| ln, err := net.Listen("tcp", ":" + strconv.Itoa(availablePort)) | ||
| ln.Close() | ||
| if err == nil { | ||
| break | ||
| } | ||
| } | ||
| return availablePort | ||
| } | ||
|
|
||
| func DownloadAndRun(image string, port int) (targetinfo IPandPort, containerID string) { | ||
|
There was a problem hiding this comment. i guess this requires refactor / better encapsulation... long and with too much statements inside if/elses. I would also not panic in this function, but return an error and make the caller to manage the errors accordingly There was a problem hiding this comment. sure, do not take this PR as ready to review. The point here is, having a first working version, understand if this docker mode should be part of the regular command or have a custom one. |
||
| ctx := context.Background() | ||
| cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation()) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| fmt.Fprintln(debugging.DebugOut,"Pulling Docker image", image) | ||
|
|
||
| out, err := cli.ImagePull(ctx, image, types.ImagePullOptions{}) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| io.Copy(debugging.DebugOut, out) | ||
|
|
||
| defer out.Close() | ||
|
|
||
| fmt.Fprintln(debugging.DebugOut, "Docker image", image, "downloaded") | ||
|
|
||
| mappedPort := "" | ||
| mapperProto := "" | ||
| if port == 0 { | ||
| // if not specific mapping defined we look for exposed ports | ||
| // getting the exposed port before decide the mapping | ||
|
|
||
| // TODO support mapping volumes, some containers required them | ||
| respCreate, err := cli.ContainerCreate(ctx, &container.Config{ | ||
| Image: image, | ||
| }, nil, nil, "") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| if err := cli.ContainerStart(ctx, respCreate.ID, types.ContainerStartOptions{}); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| respInspect := inspect(respCreate.ID) | ||
| natPorts := respInspect.NetworkSettings.NetworkSettingsBase.Ports | ||
|
|
||
| for k, _ := range natPorts { | ||
| mappedPort = k.Port() | ||
| mapperProto = k.Proto() | ||
| break | ||
| } | ||
| // Stopping container used to get the port mapping | ||
| Stop(respCreate.ID) | ||
| } else { | ||
| mappedPort = strconv.Itoa(port) | ||
| mapperProto = "tcp" | ||
| } | ||
|
|
||
| if mappedPort == "" || mapperProto != "tcp" { | ||
| panic("Not found any TCP port mapping") | ||
| } else { | ||
| fmt.Println("Internal Docker port binding:", mapperProto, mappedPort) | ||
| } | ||
|
|
||
| // hack https://stackoverflow.com/questions/47395973/issue-while-using-docker-api-for-go-cannot-import-nat | ||
|
There was a problem hiding this comment. do we need to nat / expose the port in the host 0.0.0.0? Maybe we can target the container IP if an internal subnet/bridge network is being used There was a problem hiding this comment. changing the network defaults is another option, but I considered this simpler |
||
|
|
||
| hostBinding := nat.PortBinding{ | ||
| HostIP: "0.0.0.0", | ||
| HostPort: strconv.Itoa(lookForAvailableLocalPort()), | ||
| } | ||
| containerPort, err := nat.NewPort(mapperProto, mappedPort) | ||
| if err != nil { | ||
| panic("Unable to get the port") | ||
| } | ||
|
|
||
| portBinding := nat.PortMap{containerPort: []nat.PortBinding{hostBinding}} | ||
| resp, err := cli.ContainerCreate( | ||
| context.Background(), | ||
| &container.Config{ | ||
| Image: image, | ||
| }, | ||
| &container.HostConfig{ | ||
| PortBindings: portBinding, | ||
| }, nil, "") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| fmt.Fprintln(debugging.DebugOut, "Docker container built") | ||
|
|
||
| if err := cli.ContainerStart(ctx, resp.ID, types.ContainerStartOptions{}); err != nil { | ||
| panic(err) | ||
| } | ||
| fmt.Fprintln(debugging.DebugOut, "Started docker container", resp.ID) | ||
|
|
||
| targetinfo.IP = "127.0.0.1" | ||
| targetinfo.Port, _ = strconv.Atoi(hostBinding.HostPort) | ||
|
|
||
| return targetinfo, resp.ID | ||
| } | ||
|
|
||
| func Stop(containerID string) { | ||
| ctx := context.Background() | ||
| cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation()) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| fmt.Fprintln(debugging.DebugOut, "Stopping container", containerID, "...") | ||
| if err := cli.ContainerStop(ctx, containerID, nil); err != nil { | ||
| panic(err) | ||
| } | ||
| fmt.Fprintln(debugging.DebugOut, "Container stopped successfully") | ||
| } | ||
|
|
||
| func inspect(containerID string) types.ContainerJSON { | ||
| ctx := context.Background() | ||
| cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation()) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| fmt.Fprintln(debugging.DebugOut, "Getting container info", containerID, "...") | ||
| resp, err := cli.ContainerInspect(ctx, containerID) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| return resp | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-using things like the "host" to inject the image name is a bit hacky. But that is a minor thing