Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dynamic parts of page routes when determining cachability #401

Merged
merged 2 commits into from
May 30, 2018
Merged

Include dynamic parts of page routes when determining cachability #401

merged 2 commits into from
May 30, 2018

Conversation

jimlambie
Copy link
Contributor

@jimlambie jimlambie commented May 30, 2018 •
edited
Loading

This PR improves the process of selecting a loaded endpoint based on the request URL within the cache layer.

Fix #399

@jimlambie jimlambie requested a review from abovedave May 30, 2018 01:40
abovedave
abovedave approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@abovedave abovedave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This fixes #399

@jimlambie jimlambie merged commit 218e3ad into develop May 30, 2018
@jimlambie jimlambie deleted the patch/use-params-when-locating-endpoint branch May 30, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abovedave abovedave abovedave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimlambie @abovedave