Add customOrder and disableOptimalOrderHeuristic - fix #263 merge issues
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a merge issue where the changes to layout.js in this PR (https://github.com/dagrejs/dagre/pull/263/files) didn't make it in for some reason.
cliffsun91
changed the title
customOrder and disableOptimalOrderHeuristic - fix #263 merge issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a merge issue where the changes to layout.js in #263 didn't make it in for some reason.
In the PR there are changes to two files:
lib/layout.jslib/order/index.jsThis PR was merged and the change assumed to have made it out to a recent release.
However it appears that this isn't the case when you look at the
lib/layout.json master: https://github.com/dagrejs/dagre/blob/master/lib/order/index.jsThe changes to
lib/order/index.jsmade it in however: https://github.com/dagrejs/dagre/blob/master/lib/order/index.js#L41This PR aims to add in the changes in #263 that should have made it into master when it got merged but somehow didn't.
A good summary of the issue here: OpenFn/lightning#2160 (comment)