[dagster-fivetran] Implement resync_and_poll method in FivetranClient #26062
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
0df7a52
to
4548acb
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
f8bbb3f
to
83221bd
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
4548acb
to
1368cac
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
83221bd
to
15f5427
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
1368cac
to
8610c37
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
15f5427
to
90002ef
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
8610c37
to
7f056cc
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
90002ef
to
66bd6ae
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
7f056cc
to
946d522
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
66bd6ae
to
fa28427
Compare
This was referenced Nov 21, 2024
Open
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
This was referenced Nov 21, 2024
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
fa28427
to
9da9564
Compare
maximearmstrong
force-pushed
the
maxime/implement-sync-and-poll-method-fivetran-client
branch
from
1f74e26
to
27b0a0f
Compare
maximearmstrong
force-pushed
the
maxime/implement-resync-and-poll-method-fivetran-client
branch
from
9da9564
to
f32950d
Compare
This was referenced Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR uses the resync and poll methods implemented in previous PRs to implement
resync_and_pollinFivetranClient. This method will be used in a subsequent PR to materialize Fivetran assets.Tests are added to test the full sync and poll behavior.
How I Tested These Changes
Additional unit tests with BK