Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-airlift] KubernetesPodOperator guide #26093

Open
wants to merge 1 commit into
base: dpeng817/operator-migration
Choose a base branch
from
Open

[dagster-airlift] KubernetesPodOperator guide #26093

wants to merge 1 commit into from
+238 −0

Conversation

dpeng817
Copy link
Contributor

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

@dpeng817 dpeng817 mentioned this pull request Nov 22, 2024
Open
@dpeng817 Graphite App
Copy link
Contributor Author

dpeng817 commented Nov 22, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 22, 2024
Open
Open
@dpeng817 dpeng817 marked this pull request as ready for review November 22, 2024 03:53
@graphite-app graphite-app bot added the docs-to-migrate Docs to migrate to new docs site label Nov 22, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 22, 2024

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/22/24)

1 label was added to this PR based on Christopher DeCarolis's automation.

graphite-app[bot]
graphite-app bot reviewed Nov 22, 2024
View reviewed changes
examples/docs_snippets/docs_snippets/integrations/airlift/operator_migration/using_k8s_pipes.py
return (
PipesK8sClient()
.run(
context=context.op_execution_context,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context.op_execution_context should be replaced with context. The AssetExecutionContext type can be passed directly to PipesK8sClient.run() - it doesn't have an op_execution_context attribute.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

graphite-app[bot]
graphite-app bot reviewed Nov 22, 2024
View reviewed changes
docs/content/_navigation.json Outdated
{
"title": "Migrating a KubernetesPodOperator",
"path": "/integrations/airlift/operator-migration/kubernetes-pod-operator"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing comma after the last array item - it makes the JSON invalid. The array should end with:

{
  "title": "Migrating a KubernetesPodOperator",
  "path": "/integrations/airlift/operator-migration/kubernetes-pod-operator"
}

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@dpeng817 dpeng817 force-pushed the dpeng817/k8s_docs branch 3 times, most recently from 7f40743 to a8589be Compare November 22, 2024 19:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-83muc1fho-elementl.vercel.app
https://dpeng817-k8s-docs.dagster.dagster-docs.io

Direct link to changed pages:

This was referenced Nov 23, 2024
Draft
Draft
Merged
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@neverett neverett Awaiting requested review from neverett neverett is a code owner

Assignees
No one assigned
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpeng817