-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the target Python version for Ruff commands #26094
base: master
Are you sure you want to change the base?
Conversation
@deepyaman hey, looks like
It wasn't kicked off in CI, probably because of the lack of changes in this PR. As for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make ruff
Got it. Pre-commit was actually making these changes for me, but I didn't commit them, since I thought something was wrong with my Ruff setup. 🙈 I didn't understand why upgrading the target version would make these changes; I thought maybe Ruff wasn't picking up
Ah, I didn't see this! I've gone ahead and made the requested change, but if you want to just close my PR in favor of yours, that's also understandable! |
It's fine, there shouldn't be conflicts with my PR! Or they are going to be easy to resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary & Motivation
Fix a minor inconsistency. There's no effect, because most pyupgrade rules aren't included.
(I'd be happy to introduce the pyupgrade rules, if people are open to it.)