Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-defined functions and call field in YAML format #444

Merged
merged 6 commits into from
May 1, 2023

Conversation

garunitule
Copy link
Contributor

@garunitule garunitule commented May 1, 2023

implements #429

Examples:

functions:
  - name: my_function
    params: param1 param2
    command: python main.py $param1 $param2

steps:
  - name: step 1
    call:
      function: my_function
      args:
        param1: 1
        param2: 2

Notes

  • If the general idea is good, I will implement the test

@garunitule
Copy link
Contributor Author

garunitule commented May 1, 2023

Hi, @yohamta

May I ask you to run CI's and code reviews?

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the amazing work! 👍

@yohamta yohamta merged commit 4114510 into dagu-org:main May 1, 2023
@garunitule
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants