Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 657] Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test #658

Merged
merged 1 commit into from
Aug 10, 2024
Merged

[ISSUE 657] Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test #658

merged 1 commit into from
Aug 10, 2024

Conversation

Kiyo510
Copy link
Contributor

@Kiyo510 Kiyo510 commented Aug 10, 2024

Fixes: #657

@Kiyo510 Kiyo510 changed the title [ISSUE #657] Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test [ISSUE 657] Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test Aug 10, 2024
@Kiyo510 Kiyo510 marked this pull request as ready for review August 10, 2024 19:18
@Kiyo510 Kiyo510 marked this pull request as draft August 10, 2024 19:19
@Kiyo510 Kiyo510 marked this pull request as ready for review August 10, 2024 19:20
@codecov Codecov
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (a10fff5) to head (f69c9ff).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          53       53           
  Lines        4156     4156           
=======================================
  Hits         2750     2750           
  Misses       1186     1186           
  Partials      220      220

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10fff5...f69c9ff. Read the comment docs.

yohamta
yohamta approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@yohamta yohamta merged commit 6165756 into dagu-org:main Aug 10, 2024
10 of 11 checks passed
@Kiyo510 Kiyo510 deleted the issue_657_fix_flaky_test branch August 11, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yohamta yohamta yohamta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix HTTP_HandleCancel in TestAgent_HandleHTTP was a flakey test
2 participants
@Kiyo510 @yohamta