Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for default page #729

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jonnochoo
Copy link
Contributor

@jonnochoo jonnochoo commented Nov 29, 2024

Related to #721

This allows the max items returned on the dashboard page to be adjusted according to the number of DAGs.

It feels a little hacky, so open to further thoughts?

What if we have an new API to aggregate the results? (to provide the values to the highlighted in green)
image

Or we filter the results based on time? (in red, sorry for the bad drawings) eg only show those that ran "today"

@yohamta
Copy link
Collaborator

yohamta commented Nov 29, 2024

Looking great, thank you!

It feels a little hacky, so open to further thoughts?
What if we have an new API to aggregate the results? (to provide the values to the highlighted in green)

Sounds good! However, the original reason for limiting the results was to mitigate performance issues, so I think it’s better to keep the limit for now. We can consider adding an aggregate API after we’ve improved the storage layer.

Or we filter the results based on time? (in red, sorry for the bad drawings) eg only show those that ran "today"

Yes, we actually already have this option. It shows only today’s status when the corresponding setting is enabled.

LatestStatusToday bool // Show latest status today or the latest status

@yohamta yohamta merged commit a3bda7b into dagu-org:main Nov 29, 2024
4 checks passed
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (e66978d) to head (e92dcf8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   61.67%   61.64%   -0.03%     
==========================================
  Files          53       53              
  Lines        5260     5262       +2     
==========================================
  Hits         3244     3244              
- Misses       1762     1764       +2     
  Partials      254      254              
Files with missing lines Coverage Δ
internal/config/config.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66978d...e92dcf8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants