Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(waku): link props #360

Merged
merged 5 commits into from
Jan 10, 2024
Merged

fix(waku): link props #360

merged 5 commits into from
Jan 10, 2024

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Jan 7, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 9, 2024 8:00pm

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 7, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 498cbff:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@himself65
fix: improve code
04dd0a3
@himself65
Merge remote-tracking branch 'origin/himself65/mouse-event' into hims…
498cbff 
…elf65/mouse-event

# Conflicts:
#	packages/website/src/templates/blog-article-page.tsx
dai-shi
dai-shi reviewed Jan 10, 2024
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/waku/src/router/client.ts looks good to me.

@himself65
Copy link
Contributor Author

hey we need rerun the error CI

@sandren sandren self-assigned this Jan 10, 2024
sandren
sandren approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandren

Thanks! 🙂

Yes, let's use to for the Waku Router API since it's more or less the React community standard (React Router, Remix, Gatsby, TanStack Router, etc).

@dai-shi dai-shi merged commit 59a2c60 into dai-shi:main Jan 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi left review comments

@sandren sandren sandren approved these changes

Assignees

@sandren sandren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himself65 @dai-shi @sandren