feat: better initial speed by preimporting entries #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Added a refactor commit. tbh, this doesn't make any behavioral change for me, because the other issue make it too slow. |
|
Yea, but in this case, it's better to preload since everything is ready and
at the same time, the user expects lower cold start overhead.
…On Wed, 21 Feb 2024, 06:13 Daishi Kato, ***@***.***> wrote:
Added a refactor commit.
tbh, this doesn't make any behavioral change for me, because the other
issue make it too slow.
I'm fine to merge this as the first step because it's harmless especially
in the worker.
But, my understanding was Vite prefers lazy loading and avoids eager
loading when possible.
—
Reply to this email directly, view it on GitHub
<#515 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBMICGVSHVFYELD7HNDCUTYUVNMNAVCNFSM6AAAAABDRZLT36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVG43TCMBYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to fix the initial load speed issue for #344 I scoped the code blocks to tsx and tried to pre-transform the mdx in codeToHtml since shiki was slowing the initial page load, but that didn't work and I found out that waku does not start importing the entries file unless we send an initial request.
This does not cause huge harm, but it's not ideal since we need to pre-import the entries the same way vite pre-transform some files, so we avoid the module imports and other side-effects (reading initial markdown files) overhead
For the initial page load issue, I could not find an easy solution for pre-transform the code blocks, but if we implement it at some point (cc @sandren), this PR is the initial step for it.