fix: dancing shortcut popup #3697
Conversation
Abhi-Bohora
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
@Abhi-Bohora is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
|
@sshanzel I have kept all the old code implementations as they are turns out it was just an if condition in useEffect that was causing this issue. Thanks for your response; I was going down the wrong path before. I have built and tested this. |
Great to see you found an alternative. This is also a heavily used hook, seeing how the changes turned out to be simpler would make testing easier. |
|
@sshanzel thanks for the review, I hope this was the solution you are looking for |
|
Tested it and indeed the |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Changes
Linked Issue: (dailydotdev/daily#1357)
Describe what this PR does
This pr aims to fix the shortcut link input box UI glitch in the extension of daily.dev as shown in the video in the linked issue whenever users try to input a shortcut link and enter an invalid URL the input box begins to glitch up and down infinitely. I think this was caused by a condition check in a useEffect that created an infinite loop.
note: I have tested this only in Chrome I believe it should work for another browser extension too.
After changes
Untitled.video.-.Made.with.Clipchamp.mp4
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR