feat: top reader in user short info #3748
Conversation
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
omBratteng
force-pushed
the
AS-670-top-reader-user-info
branch
from
d2ad478
to
0cd48a8
Compare
| {topReader && ( | ||
| <> | ||
| <Separator /> | ||
| <SimpleTooltip |
There was a problem hiding this comment.
Why do we tooltip here and not on the other one?
Maybe we can abstract into common component rather?
There was a problem hiding this comment.
Mostly because UserShortInfo is used in the user lists, where that row already has a tooltip, so adding a second tooltip doesn't really work well 😬
There was a problem hiding this comment.
I see, I see :) no worries.
We could do generic component and make tooltip optional, wdyt?
There was a problem hiding this comment.
Yeah, I can do that :)
| {transformUsername ? transformUsername(user) : `@${username}`} | ||
| </TruncateText> | ||
|
|
||
| {topReader && ( |
There was a problem hiding this comment.
Re-used again, so component might be good
omBratteng
force-pushed
the
AS-670-top-reader-user-info
branch
from
8d7342e
to
6febe5d
Compare
Co-authored-by: Chris Bongers <[email protected]>
| {topReader && ( | ||
| <> | ||
| <Separator /> | ||
| <TopReaderIn topReader={topReader} tooltip /> |
There was a problem hiding this comment.
We might have to truncate this whole row? Probably noticeable on mobile devices.
There was a problem hiding this comment.
Can you add these comments to #3739?
There was a problem hiding this comment.
Apologies, I just got back to my GH emails 🙈
I will check if this hasn't been resolved.
| <Separator /> | ||
| <TopReaderIn topReader={author.topReader} /> |
There was a problem hiding this comment.
Same here, we should maybe truncate it.
There was a problem hiding this comment.
Can you add these comments to #3739?
Changes
Depends on dailydotdev/daily-api#2382
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-670
Preview domain
https://as-670-top-reader-user-info.preview.app.daily.dev
Preview inline in comment
https://as-670-top-reader-user-info.preview.app.daily.dev/posts/dream-machine--7agaxxtvx