fix: preview modal ui to match figma #3798
Conversation
ilasw
requested review from
rebelchris,
omBratteng,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| @@ -67,7 +68,7 @@ function PostModerationModal({ | |||
| size={Modal.Size.Large} | |||
| kind={Modal.Kind.FlexibleTop} | |||
| > | |||
| <Modal.Body className="gap-6"> | |||
| <Modal.Body className="gap-6 !p-6"> | |||
There was a problem hiding this comment.
Can we not override the padding without using important? I think we should avoid it whenever necessary
There was a problem hiding this comment.
Unfortunately this is not possible due to the order in which the classes are written by TailwindCSS.
We have discussed this issue internally in the past and proposed using twMerge but it has not been adopted yet :(
There was a problem hiding this comment.
For this it's fine, ideally all modals follow guidelines, but this is a weird modal I guess.
| )} | ||
| <ModalClose onClick={modalProps.onRequestClose} /> | ||
| <ModalClose | ||
| className="relative !right-0" |
There was a problem hiding this comment.
ModalClose actually accepts props to adjust right- :)
There was a problem hiding this comment.
Nice! Didn't see before, thanks for suggesting! 🙏
| )} | ||
| <ModalClose onClick={modalProps.onRequestClose} /> | ||
| <ModalClose | ||
| className="relative !right-0" |
There was a problem hiding this comment.
ModalClose actually accepts props to adjust right- :)
| @@ -67,7 +68,7 @@ function PostModerationModal({ | |||
| size={Modal.Size.Large} | |||
| kind={Modal.Kind.FlexibleTop} | |||
| > | |||
| <Modal.Body className="gap-6"> | |||
| <Modal.Body className="gap-6 !p-6"> | |||
There was a problem hiding this comment.
For this it's fine, ideally all modals follow guidelines, but this is a weird modal I guess.
…-modal-preview-ui
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://fix-modal-preview-ui.preview.app.daily.dev