Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AVX2 code and remove its "yolocrypto" designation #146

Merged
merged 25 commits into from
Jun 21, 2018
Merged

Refactor AVX2 code and remove its "yolocrypto" designation #146

merged 25 commits into from
Jun 21, 2018

Conversation

hdevalence
Copy link
Contributor

This changeset rewrites the AVX2 code from a proof-of-concept to something that matches the quality standards of the rest of our code.

It also documents the formulas used, the implementation strategy, the design tradeoffs, and the coefficient bounds.

It removes the yolocrypto flag from the avx2_backend.

Closes #142.

hdevalence added 24 commits June 14, 2018 14:05
@hdevalence
some rustfmt changes
bd1e3c5
@hdevalence
Implement addition for FieldElement32x4
c8dc2a6
@hdevalence
Add a shuffling abstraction for FieldElement32x4
14ce6d3
@hdevalence
Change negate_D, negate_D_lazy to impl Neg, negate_lazy
00d8b6e
@hdevalence
Make platform-vector lanes constants private
64cb999
@hdevalence
Add more selectors to the Lanes enum
30a2b01
@hdevalence
Rewrite the doubling horrorshow
794ed5c
@hdevalence
Change Lanes::ALL to Lanes::ABCD for consistency
28f10bc
@hdevalence
Add comment about rustc-constant-info to blend function
cc8728b
@hdevalence
Eliminate vector constants from edwards module
25d9f3f
@hdevalence
Delete unused constant
02296fa
@hdevalence
Replace special-case swap_{AB,CD} methods with general shuffles
eea3ead
@hdevalence
Add documentation
c46ec96
@hdevalence
Don't expose u32x8 unpacking functions
fe51ada
@hdevalence
Rewrite diff_sum in terms of shuffle, blend, negate
64b1b48
@hdevalence
Move blend_lanes into the blend function
4dc2199
@hdevalence
Move packing functions to top of the module
97292fe
@hdevalence
Make publicity a little more consistent
6ef9e9d
@hdevalence
Replace scale_by_curve_constants by a Mul<(u32,u32,u32,u32)> impl
bab1ebb
@hdevalence
Rename reduce32 to reduce and have it return its result.
9f5bd8c 
This means that all FieldElement32x4 operations return values, vs mutating interior state.
@hdevalence
Document bounds on FieldElement32x4 functions
7198719
@hdevalence
Suppress extraneous warnings
15f9722
@hdevalence
Rewrite notes and documentation.
d791047
@hdevalence
Remove yolocrypto from avx2_backend
16f39c8
@hdevalence hdevalence requested a review from isislovecruft June 18, 2018 20:39
@hdevalence
Copy link
Contributor Author

hdevalence commented Jun 21, 2018 •
edited
Loading

The docs for the AVX2 backend don't build because Rustdoc isn't aware of target_feature (upstream bug rust-lang/rust#46317). In the meantime maybe it would be good to add a documentation feature that we could use to build docs for all internal modules?

Edit: this doesn't work, since the different backends can't be built simultaneously.

@hdevalence hdevalence merged commit 3d14343 into dalek-cryptography:develop Jun 21, 2018
@hdevalence hdevalence deleted the refactor-avx2 branch June 21, 2018 23:40
pinkforest pushed a commit to pinkforest/curve25519-dalek that referenced this pull request Jun 27, 2023
@isislovecruft
Merge pull request dalek-cryptography#146 from xu-cheng/serde2
97c22f2 
Fix serde implementation for serde_json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isislovecruft isislovecruft isislovecruft approved these changes

Assignees
No one assigned
Labels
efficiency - speed enhancement research - cryptography
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdevalence @isislovecruft