Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained optional dependency "esdoc"? #44

Open
AndreasRadsziwill6447 opened this issue Aug 3, 2022 · 2 comments
Open

Remove unmaintained optional dependency "esdoc"? #44

AndreasRadsziwill6447 opened this issue Aug 3, 2022 · 2 comments

Comments

@AndreasRadsziwill6447
Copy link

Can the optional dependency on "esdoc" be removed?

This project doesn't seem to use it, as there is no .esdoc.json file anywhere.
Also esdoc is not actively maintained anymore (last commit in 2018) and causes security alerts in downstream projects because of outdated dependencies e.g. marked and nth-check
mrclrchtr added a commit to mrclrchtr/danger-plugin-lint-report that referenced this issue Apr 13, 2023
@mrclrchtr
fix: remove optionalDependency 'esdoc' because it is unused and outda…
796a6a6 
…ted (damian-burke#44)
@mrclrchtr mrclrchtr mentioned this issue Apr 13, 2023
Merged
@mrclrchtr
Copy link
Contributor

I have created a PR for this: #50

@mrclrchtr
Copy link
Contributor

@damian-burke what do you think?
There are also some dependency upgrade PRs in this Repo.
Do you still maintain the plugin or should we create a fork and maintain it ourselves?

Rouby pushed a commit that referenced this issue May 16, 2023
@mrclrchtr @Rouby
fix: remove optionalDependency 'esdoc' because it is unused and outda…
c868b5a 
…ted (#44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrclrchtr @AndreasRadsziwill6447