Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid regular expressions in grammar #7

Closed
lildude opened this issue Jun 19, 2023 · 0 comments · Fixed by #10
Closed

Invalid regular expressions in grammar #7

lildude opened this issue Jun 19, 2023 · 0 comments · Fixed by #10
Assignees

Comments

@lildude
Copy link

lildude commented Jun 19, 2023

👋 from github-linguist/linguist which uses this grammar for syntax highlighting Move files on GitHub.com.

I'm in the process of creating the next release and I've seen our grammar compiler has detected the grammar has two invalid regular expressions which may impact the highlighting of some Move files:

  • repository vendor/grammars/vscode-move-syntax (from https://github.com/damirka/vscode-move-syntax.git) (2 errors)
    • Invalid regex in grammar: source.move (in syntaxes/move.tmLanguage.json) contains a malformed regex (regex "(?<=(module|spec))": lookbehind assertion is not fixed length (at offset 17))
    • Invalid regex in grammar: source.move (in syntaxes/move.tmLanguage.json) contains a malformed regex (regex "(?<=(module|spec))": lookbehind assertion is not fixed length (at offset 17))

I won't hold back the release for this to be fixed, but I will be adding this to the list of known grammar issues: github-linguist/linguist#3924. Any fixes you make to this grammar will be pulled in when the next release is made.

@damirka damirka self-assigned this Oct 23, 2023
damirka added a commit that referenced this issue Sep 5, 2024
damirka added a commit that referenced this issue Sep 5, 2024
* fixes #7
* beep
* removes simple.move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants