Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raml-rb gem #23

Merged
merged 12 commits into from
May 22, 2016
Merged

Update raml-rb gem #23

merged 12 commits into from
May 22, 2016

Conversation

danascheider
Copy link
Owner

This updates the required version of the raml-rb gem to 0.0.6, which has not yet been released.

@dolan
Copy link

dolan commented May 21, 2016

Have you considered using a complete RAML parser? Working around raml-rb's limitations seems like a fool's errand. https://github.com/coub/raml_ruby already does all of the attributes, and you can ignore/skip the ones you don't want to use. This would make it so that nobody has to trim out the unsupported attributes in their actual RAML files (which need to be complete if they're generating documentation, with something like raml2html) just to work with rambo.

@danascheider
Copy link
Owner Author

@dolan Yeah, for some reason when I initially looked for a RAML parser, raml-rb was the one I found. Now that I know there are others I'm definitely looking at making the switch. The good news is we now have a second full-time dev working on Rambo, so these things will hopefully be resolved more quickly in the future. Believe me, we're paying two full-time devs for this (including me) - we need it to work too!

@dolan
Copy link

dolan commented May 21, 2016

Glad to hear it. I hope you don't think I'm trying to heckle you. I thought that there just might have been a reason that I didn't understand.

@danascheider
Copy link
Owner Author

Not at all, I appreciate the suggestion and had been thinking about making the change. Initially, I wasn't aware there were better options, so now I just have to figure out how many changes I'd need to make to incorporate a different gem, since I doubt it's a drop-in replacement.

@danascheider
Copy link
Owner Author

Besides which, I'm an open source maintainer - I'm always glad to see people interested in my projects, especially if they seem to know what they're talking about!

@danascheider
Copy link
Owner Author

@dolan So it looks like the raml_ruby gem is not actually published to Rubygems, which makes it very difficult to include in the project without some ugly hacks. I'm going to keep looking to see if there's another more complete parser.

@dolan
Copy link

dolan commented May 21, 2016

@danascheider
Copy link
Owner Author

Huh, I guess they just didn't update the README? In any case, thanks!

@danascheider
Copy link
Owner Author

@dolan So I did a spike today to replace raml-rb with raml_ruby, and it turns out that the latter does not support the RAML 1.0 specification, which all of our projects use. Maybe @zeisler would be able to contribute RAML 1.0 support to raml_ruby, but for the time being I'm going to switch back to raml-rb. Frustrating that there isn't a better solution.

@danascheider
Copy link
Owner Author

@jpb - any chance you could publish v. 0.6 to Rubygems?

@jpb
Copy link

jpb commented May 22, 2016

@danascheider done 👍

@danascheider
Copy link
Owner Author

Yay! Thanks!

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-0.8%) to 98.263% when pulling 552bc9d on update-dependencies into 312d3a6 on master.

@danascheider danascheider force-pushed the update-dependencies branch from 3d23542 to 72372a0 Compare May 22, 2016 02:54
@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-5.9%) to 93.316% when pulling 72372a0 on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-4.4%) to 94.832% when pulling be6a92a on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-3.1%) to 96.124% when pulling 6374ccd on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-3.1%) to 96.114% when pulling faebd8c on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-2.3%) to 96.891% when pulling 5e186c9 on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-0.5%) to 98.715% when pulling a116b27 on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-0.5%) to 98.715% when pulling 5b44de1 on update-dependencies into f786ffb on master.

@danascheider danascheider changed the title DO NOT MERGE: Update raml-rb gem Update raml-rb gem May 22, 2016
@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-0.8%) to 98.469% when pulling 728bb91 on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage decreased (-0.8%) to 98.458% when pulling 5a0cff7 on update-dependencies into f786ffb on master.

@coveralls
Copy link

coveralls commented May 22, 2016

Coverage Status

Coverage increased (+0.006%) to 99.235% when pulling 4a7f5cd on update-dependencies into f786ffb on master.

@danascheider danascheider merged commit 0a20196 into master May 22, 2016
@danascheider danascheider deleted the update-dependencies branch May 22, 2016 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants