Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Latest testing, collections do not load (Related to PascalCase changes?) #4682

Closed
jb2barrels opened this issue Jun 27, 2024 · 8 comments · Fixed by #4685
Closed

[Bug] Latest testing, collections do not load (Related to PascalCase changes?) #4682

jb2barrels opened this issue Jun 27, 2024 · 8 comments · Fixed by #4685

Comments

@jb2barrels
Copy link

Subject of the issue

Collections tree in the filters box does not show all collections after upgrading to latest testing. (Maybe related to the latest PascalCase changes?)

Deployment environment

  • vaultwarden version: testing (Latest) - As of June 27 2024
  • Install method: Docker Compose

  • Clients used:
    Web vault

  • Reverse proxy and version:
    Nginx Proxy Manager with SSL

Steps to reproduce

Expected behaviour

Collections tree should load under the filters section.

Example screenshot, where it shows collections do exists but do not show up in the collections tree on the left.
image

@BlackDex
Copy link
Collaborator

Probably related to #4681, but could be something different.

@stefan0xC
Copy link
Contributor

stefan0xC commented Jun 27, 2024

It also happens on vault.bitwarden.com so this probably unrelated to vaultwarden (might even be intentional).
cf. bitwarden/clients#9823

@jb2barrels
Copy link
Author

jb2barrels commented Jun 27, 2024

It also happens on vault.bitwarden.com so this probably unrelated to vaultwarden (might even be intentional). cf. bitwarden/clients#9823

I was able to rollback to the June 20th build of vaultwarden (via doing a docker build) - which has the Web vault 2024.5.1 (collections issue is not present in that vaultwarden build):
8f05a90

So it seems the admin collections issue crept in on vaultwarden between June 23rd - June 24th.
I don't see a web vault update between those dates, so I do wonder if the above is a coincidence or some recent change that was somewhat copied over from Bitwarden into Vaultwarden.

@stefan0xC
Copy link
Contributor

seems like this setting is responsible for the behavior:

"flexibleCollections": true,

@BlackDex
Copy link
Collaborator

Ah, we can set that back to false for now. And add flex/v2 later.

dfunkt added a commit to dfunkt/vaultwarden that referenced this issue Jun 28, 2024
@stefan0xC
Copy link
Contributor

stefan0xC commented Jun 28, 2024

Ah, we can set that back to false for now. And add flex/v2 later.

I don't think those two are that related (like I said dani-garcia/bw_web_builds#169 (comment) the new endpoint is already used instead). To actually implement flexible collections we will have to change more stuff (not sure if this is everything but that's what I've noted down so far)

  • Implement Custom User Permissions
  • Deprecate Manager role and write migration to set new "can manage" permission over assigned collections.
  • Deprecate "Access All" Flag and write migration to apply "can manage" permission to all collections.
  • Add new /api/organizations/<org_uuid>/collections/bulk-access endpoint for new bulk collection assignment
  • Support option to limit creation/deletion of collections to owners/admins.
  • Adapt the collections_v2 endpoint to return "unvailable": true if the cipher becomes unavailable due to changed permissions. (edit: Or rather this might be missing from my PR. I have not really looked at it that deeply.)

@BlackDex
Copy link
Collaborator

Oef. That sounds to me like a Backup your database first before update situation.

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Jun 28, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}`
as there `data` value. This isn't allowed. When detected, replace it
with `{"type":0}`

Fixes dani-garcia#4682
dfunkt pushed a commit to dfunkt/vaultwarden that referenced this issue Jun 28, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}`
as there `data` value. This isn't allowed. When detected, replace it
with `{"type":0}`

Fixes dani-garcia#4682
@BlackDex
Copy link
Collaborator

I created a PR to fix this specific issue, and a small issue i found with the new native app. #4685

dfunkt pushed a commit to dfunkt/vaultwarden that referenced this issue Jun 30, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}`
as there `data` value. This isn't allowed. When detected, replace it
with `{"type":0}`

Fixes dani-garcia#4682
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Jul 3, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}` or `{"type":null}` as there `data` value.
This isn't allowed. When detected, replace it with `{"type":0}`

Fixes dani-garcia#4682
Fixes dani-garcia#4590
dani-garcia pushed a commit that referenced this issue Jul 3, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}` or `{"type":null}` as there `data` value.
This isn't allowed. When detected, replace it with `{"type":0}`

Fixes #4682
Fixes #4590
ZhReimu pushed a commit to ZhReimu/vaultwarden that referenced this issue Jul 9, 2024
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}` or `{"type":null}` as there `data` value.
This isn't allowed. When detected, replace it with `{"type":0}`

Fixes dani-garcia#4682
Fixes dani-garcia#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants