Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white background colour to Radio and Checkbox components #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robpataki
Copy link

Add white background colour to the Radio and Checkbox components as per #554.

@robpataki robpataki changed the title Add background colour to Radio and Checkbox components Add white background colour to Radio and Checkbox components Jan 13, 2023
@daniel-ac-martin
Copy link
Owner

I think this is fine as a simple workaround, but what we really need to do is understand why the discrepancy is present, and also whether we are out of sync with govuk-frontend which is really upstream from this library.

There are some occasions where we might choose to diverge from govuk-frontend, but we should do so very sparingly and know exactly why we are doing it.

@robpataki
Copy link
Author

@daniel-ac-martin NOTGOVUK is actually sticking to the GOVUK styles, and interestingly I am not sure why the source UI components don't apply the same white background to radios and checkboxes as it does to text inputs, text areas and selects. I've found a stale Github thread (alphagov/govuk-frontend#1625), it seems from the 2019 conversations that there might be a reason why these controls have transparent background, but the then-current team wasn't sure what that reason was. Hopefully we get some clarification on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants