Update to Keycloak 25 #166
Conversation
|
Hi! Thanks for the contribution! For the changes to work, you will also need to update:
Here's a link to the EDIT: |
daniel-frak
added
the
requested changes
README.md
Outdated
| @@ -22,7 +22,8 @@ https://codesoapbox.dev/keycloak-user-migration | |||
|
|
|||
| | Keycloak Version | Version/Commit | | |||
| |------------------|----------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | 24.X | [4.0.0](https://github.com/daniel-frak/keycloak-user-migration/releases/tag/4.0.0) | | |||
| | 25.X | [5.0.0](https://github.com/daniel-frak/keycloak-user-migration/releases/tag/5.0.0) | | |||
There was a problem hiding this comment.
This version should just be be SNAPSHOT (with no links). The release workflow will change it to the correct tag automatically and that way we won't have dead links.
|
Thanks! I just noticed that the end-to-end tests are failing, however :/ Do you feel like you can tackle that as well, or would you like me to help? |
|
Looks like a theme change. But sorry to say I have no frontend competency at all. Please help if you have time. Otherwise I ca ask one of my colleagues later this week.
|
|
Ok, I'll try to carve out some time near the end of this week to take a look. |
|
Ok, this is a bit weird. I cloned your repo locally and ran the E2E tests, and they pass. Looking at the code, the issue is at this place ( cy.get('#kc-forgot-pw-switch').then(($checkbox) => {
if (!$checkbox.prop('checked')) {
cy.wrap($checkbox).check({ force: true });
cy.get('.pf-c-alert__title').should('contain', "Forgot password changed successfully");
}
});For whatever reason, when checking the "Forgot password" checkbox in Keycloak's Realm settings, the confirmation popup is not being detected by Cypress, but seemingly only on CI. Unfortunately I'm also not too adept in frontend technologies, so we'll have to play this one by ear, a bit. If any of your colleagues know Cypress and would like to contribute their knowledge, that would also be appreciated :)
cy.get('#kc-forgot-pw-switch').then(($checkbox) => {
if (!$checkbox.prop('checked')) {
cy.intercept('PUT', '/admin/realms/master') // Add this
.as("saveRealmSettings");
cy.wrap($checkbox).check({ force: true });
cy.wait("@saveRealmSettings"); // And this
cy.get('.pf-c-alert__title').should('contain', "Forgot password changed successfully");
}
});
|
|
@daniel-frak regarding running the tests locally, I get the same error: Inspecting the HTML, it looks like the style has changed (Keycloak team upgraded to Patternfly 5) from |
|
Weirdly, I'm getting the same error (which I probably should have mentioned) when running your code, unless I increase the wait time of However, I don't get the second error that you're getting... For me, the What happens if you change the code like I did (adding the On my side, I'll try to find some time to reconfirm the |
|
@pnzrr Can you look at this? |
|
Upon a closer look, it seems that the E2E tests have become generally flaky (even on the I've improved them somewhat on the main branch. Could you pull from In the meantime, I'll do some more investigating regarding the tests... EDIT: After the most recent refactoring on the |
|
@xgp Just a quick reminder about the rebase, so that we can merge the PR :) |
|
Ah, shucks :/ I'll try to find some time to confirm if the tests are just flaky here. If that's the case, I'll merge the PR and try to fix the test flakiness later... |
|
@xgp Ok, so I took a look at your branch and it seems that the change you made, where you replaced Not sure why |
|
I still can't get tests to pass locally, even when reverting that change. I'm somewhat out of my element on these tests. As much as I've tried, I'm really unable to grok what's going on. |
|
Yeah, frontend's a bit of a mystery for me as well XD But it does pass on my machine after the revert, so let's get it to that state and I'll merge it in, to not waste more of your time on the E2E test side. Then I'll try to find some free time to stabilize the tests on the main branch. |
|
25.0.021, now the Keycloak standard per https://www.keycloak.org/2024/06/keycloak-2500-released.html#_java_21_support and https://www.keycloak.org/2024/06/keycloak-2500-released.html#_java_17_support_is_deprecatedkeycloak-model-legacytokeycloak-model-storageper Map Storage Removal: Remove deprecated model/legacy module keycloak/keycloak#26657