Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versioned buckets: list, rename, delete #134

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

Zhell1
Copy link
Contributor

@Zhell1 Zhell1 commented Nov 24, 2021

  • make [list, rename, delete] actions on jupyterlab work with versioned buckets (and not display delete markers)
  • add minio-distributed environement in makefile to make testing versioning possible
  • add some logging & doc for the pain points I encountered

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@danielfrg
Copy link
Owner

Thank you very much for the PR. I made a couple of small comments on docs and linting but nothing major.

Since this uses MinIO for testing it would be cool to have CI for it, probably in this case it would mean a different github action. It would be interesting but not necessary.

@danielfrg
Copy link
Owner

Ugh, somethign failing on the environment validation. I will take a look today and rebase here.

@danielfrg
Copy link
Owner

I fixed the CI issues so I am just going to merge since tests passed before you made the doc fixes.

Thank you for the PR!

@Zhell1
Copy link
Contributor Author

Zhell1 commented Nov 30, 2021

Thank you for such a quick reaction on this, you made contributing an awesome experience 🙏

@danielfrg
Copy link
Owner

Thanks! I will do a release hopefully tomorrow.

@danielfrg
Copy link
Owner

Version 0.9.0 is released including this.

@Zhell1
Copy link
Contributor Author

Zhell1 commented Dec 1, 2021

Thank you for your diligence !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants