fix event greylist stuck #786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgerlag
reviewed
Mar 4, 2021
| @@ -36,6 +36,7 @@ protected override async Task ProcessItem(string itemId, CancellationToken cance | |||
| if (!await _lockProvider.AcquireLock($"evt:{itemId}", cancellationToken)) | |||
| { | |||
| Logger.LogInformation($"Event locked {itemId}"); | |||
| await QueueProvider.QueueWork(itemId, QueueType.Event); | |||
There was a problem hiding this comment.
Could this cause a poison message?
There was a problem hiding this comment.
This line may be. Actually it looks like adding to a queue when failing to acqure an evt lock is a bad idea. But it is necessary when failing to acquire a workflow lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #722