Hotfix/checkout fails in ci

[JulienGrv]

Git checkout is failing in CI for branches in fork repositories but also for PR somehow because the token SUBMODULE_PAT only exists for the asammdf repository. I removed the token because it should not be needed as libdeflate is a public repository (tested in my repository and it worked) or is there any reason why it might be needed that I overlooked?

[danielhrisca]

From what I saw the submodule was not properly retrieved in the github actions jobs without the token

[JulienGrv]

Tests pipelines are passing so it works without token. I have to check for the other pipelines. If you look at my other opened pull requests where I did not edit the main.yml, you will see that tests pipelines are failing because the token is required, which does not work because I don't have a SUBMODULE_PAT token defined in my repository settings. I could add it but it should not be necessary because libdeflate is a public repository.

I will look at the other pipelines though. Maybe we need to update to checkout v4.

I will come back to you with more info

[JulienGrv]

I removed the token for all the pipelines/workflows and they are all able to checkout now (tests, wheels, coveralls, and pyinstaller_build).

The reason it was failing with the token is that: SUBMODULE_PAT is a secret that only exists in your repository and is not accessible for branches and PR coming from other repositories. To fix this I removed the token. I don't know why you added the token initially because from my understanding it is not necessary to have it in order to clone libdeflate because libdeflate is a public repository on github.com

[danielhrisca]

let me know when your pull requests are ready

[JulienGrv]

@danielhrisca this one is ready to merge thank you

[danielhrisca]

thanks