Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tox does not install extras if they have underscores in their name #1138

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: tox does not install extras if they have underscores in their name #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ dependencies = [
decode = ["faust-cchardet==2.1.19", "chardet"]
export = ["pyarrow", "h5py", "hdf5storage>=0.1.19", "python-snappy", "polars"]
testing = ["h5py", "pyarrow", "python-can", "scipy"]
export_matlab_v5 = ["scipy"]
export-matlab-v5 = ["scipy"]
gui = ["natsort", "PySide6", "pyqtgraph", "pyqtlet2[PySide6]", "packaging"]
encryption = ["cryptography", "keyring"]
symbolic_math = ["sympy"]
symbolic-math = ["sympy"]
filesystem = ["fsspec"]

[project.scripts]
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Development dependencies
--editable .[decode,encryption,export,export_matlab_v5,filesystem,gui,symbolic_math]
--editable .[decode,encryption,export,export-matlab-v5,filesystem,gui,symbolic-math]
--requirement benchmarks/requirements.txt
--requirement ci/requirements.txt
--requirement doc/requirements.txt
Expand Down
3 changes: 2 additions & 1 deletion test/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ PyAutoGUI
pytest
pytest-cov
pytest-timeout
xmlrunner; python_version < "3.12"
python-can
xmlrunner; python_version < "3.12"
11 changes: 6 additions & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ envlist = py39, py310, py311, py312, py313, black, mypy, ruff, doc
deps =
--requirement test/requirements.txt
extras =
export
export-matlab-v5
gui
testing
passenv = DISPLAY,XAUTHORITY
setenv =
DISPLAY = :0
Expand All @@ -35,10 +36,10 @@ extras =
decode
encryption
export
export_matlab_v5
export-matlab-v5
filesystem
gui
symbolic_math
symbolic-math
commands =
mypy

Expand All @@ -64,9 +65,9 @@ extras =
decode
encryption
export
export_matlab_v5
export-matlab-v5
gui
symbolic_math
symbolic-math
commands =
pyinstaller asammdf.spec {posargs}

Expand Down
Loading