Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configure buglet; verify bit-for-bit identical installs; enhance junit output; add builders. #7

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Fix configure buglet; verify bit-for-bit identical installs; enhance junit output; add builders. #7

wants to merge 10 commits into from

Conversation

dankegel
Copy link
Owner

Fixes madler#497 and madler#499

  • Adds Mac, BSD, Ubuntu, Fedora, and Debian builders
  • Verifies that cmake and configure builds produce identical installs on all non-windows platforms
  • Adds proper line/file info to junit output so cirrus-ci builds yield good error annotations on github pull requests.
  • New --force_fail option to make testing the above possible without temporary code changes
  • --junit no longer disables normal test output
  • New --fast_fail option; default is now don't abort on first failure.
  • minor tidying

dankegel added 10 commits May 25, 2020 20:57
@dankegel
cmake: adjust to produce same results as configure/make; fixes madler…
182a4ee 
…#497

- default build type to Release
- set -DHIDDEN properly
- pass .c files to compiler in same order
- on linux/bsd, link libz.so with -lc explicitly (as Makefile.in does, but why?)
- output same libz.pc and zconf.h as Make
@dankegel
configure: don't pull in stale zconf.h; fixes madler#499
06c8b96
@dankegel
ci: add linux/bsd/osx builders to verify madler#497 and madler#499 fixes
0fff29e 
ci/pkgcheck.sh: verify make and cmake install same bits, and
that running configure/make doesn't try to reference wrong zconf.h.
@dankegel
example.c: tidy exit check on error
443a29e
@dankegel
example.c: error message didn't end in newline
ea43f4c
@dankegel
example.c: print error if given unknown option
f3bcb3f 
Also don't assume there will only be one option.
@dankegel
example.c: add --force_fail option to ease manual test of error repor…
53ae4a5 
…ting
@dankegel
cmake: add JUNIT option. ci: use it.
30abeec 
This lets the Linux build upload results for both tests (example and example64).
@dankegel
example.c: --junit no longer disables normal output
a3050c0 
The choice of output formats used to be intertwined with
whether to terminate on first failure.
New default is to not terminate on first failure,
regardless of output formats; use --fail_fast
if you want to stop the test on the first failure.
@dankegel
example.c: enhance junit output so show github shows precise error an…
eb3077a 
…notations
@dankegel dankegel force-pushed the issues-497-499-identical-output-and-mucho-ci branch 2 times, most recently from 1a21f13 to eb3077a Compare May 26, 2020 22:10
@dankegel dankegel mentioned this pull request May 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dankegel