hevm: implement subroutines #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChico
reviewed
Jun 15, 2020
|
CI failed due to #395 😢 |
|
there are some other proposed changes to this EIP that have been discussed here, not sure what the current status is |
|
rebased on |
They seem to be somewhat controversial: ethereum/EIPs#2663 |
|
subroutines are dropped from berlin: ethereum/pm#263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements subroutines based on the spec at: https://eips.ethereum.org/EIPS/eip-2315
This code passes all the tests here: https://github.com/ethereum/tests/tree/develop/BlockchainTests/GeneralStateTests/stSubroutine
For some reason I couldn't get
hevm complianceto run these tests (they work fine withhevm bc-testhowever....), so I didn't update the commit forethereum/testsinrelease.nixyet @MrChico @livnev do you have any ideas?I'm also wondering if we want to add some visualization of the current state of the
return_stacktohevmin some future PR?I’m also not sure if it makes sense to reuse the
BadJumpDestinationandStackLimitExceedederrors or make new ones for the subroutines context?