Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Port standardization #35

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Port standardization #35

merged 6 commits into from
Oct 19, 2022

Conversation

tropicar
Copy link
Contributor

@tropicar tropicar commented Jul 1, 2022

According to this issue dappnode/DAppNode#457
We are selecting the host port for the client.

In prysm client you can change these default ports using these flags:

   --p2p-tcp-port value            The port used by libp2p. (default: 13000)
   --p2p-udp-port value            The port used by discv5. (default: 12000)

@pablomendezroyo
Copy link
Contributor

there are up to three possible prysm packages (prater eth2 and gnosis chain). How do we handle this situation if the three packages want to use the same hot port?

@tropicar
Copy link
Contributor Author

tropicar commented Jul 8, 2022

there are up to three possible prysm packages (prater eth2 and gnosis chain). How do we handle this situation if the three packages want to use the same hot port?

The port is defined in the next way; chainID multiplied by 10 + default port + clientID(this number is defined by us). You can read the specific feature here dappnode/DAppNode#457

For that specific case:
Prysm: TCP/13103 & UDP/12103
Prysm Prater: TCP/13503 & UDP/12503
Prysm Gnosis: TCP/14003 & UDP/13003
With the chainID we avoid the collision in the same clients with different networks
Multiply by ten because because of the testnets has the same client and chainIDs have similar values (and how they use the same client, clientID and deffault port are the same ).

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@alexpeterson91 alexpeterson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the right ports according to the spec you defined

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@alexpeterson91 alexpeterson91 merged commit 8765f6d into main Oct 19, 2022
@alexpeterson91 alexpeterson91 deleted the tropicar/port-standardization branch October 19, 2022 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants