Changes for next Shutter Network release #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
force-pushed
the
feat/shutter-next
branch
from
e1f7eaf to
d9d0a0b
Compare
- The container image name has changed to `ghcr.io/shutter-network/keyper` - The assets image tag format was changed to be consistent between testnet and mainnet - A new assets variable `_ASSETS_NETWORK` was introduced and now gets exported in the metrics push Also the script function to replace the env var placeholders was removed since vmagent does this automatically (see: https://docs.victoriametrics.com/vmagent/#how-to-collect-metrics-in-prometheus-format)
ulope
force-pushed
the
feat/shutter-next
branch
from
d9d0a0b to
665f659
Compare
Marketen
approved these changes
Nov 22, 2024
|
Looks fine. @ulope I have built & installed the package with this PR in my dappnode and didnt encounter any problems, but I probably lack context on shutter network in order to test it correctly. Has anyone else tested this PR in a working dappnode? |
|
On our side @konradkonrad tried setting it up in an actual dappnode (you talked in chat with him) |
The go-shutter-settings config parser choked on two string array fields, which previously were marked as only string.
Otherwise, we will not have the proper db connection for initialization.
konradkonrad
force-pushed
the
feat/shutter-next
branch
from
3924c1d to
8f568db
Compare
Using the staker script provided functions did not lead to correct use of form-config provided values for clients.
Merged
|
Part of this PR has been already merged by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghcr.io/shutter-network/keyper_ASSETS_NETWORKwas introduced and now gets exported in the metrics pushAlso the script function to replace the env var placeholders was removed since vmagent does this automatically (see: https://docs.victoriametrics.com/vmagent/#how-to-collect-metrics-in-prometheus-format)