expression_weighted.get_weight() and expression_weighted.set_weight() now use the correct input_id #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now use the correct input_id
… and is in line with the rest of the code, where unsigned is used everywhere
|
To avoid implicit downcasts in the get/set_weight function I changed the types for node_id and input_id to unsigned (instead of size_type). The CI OSX debug build should now pass. I think the changes are in line with the rest of the code where unsigned is used for node_id consistently, but please let me know if there is something to improve. |
|
Thanks for this PR. I am now working on the pybind11, will merge after that is concluded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56 .
I added test for expression_weighted for all four methods that get/set weights (both single weights and the whole vector).