-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gift selected planets plugin #178
Conversation
Its maybe unfortunate that you and fromddy made the same plugin idea at the same time #179 In the guidelines it says: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the code and tested it and it worked.
ideas:
- The choose someone list could be sorted alphabetically, you can click on the list and type a letter to jump to the first user with that letter
- the address inputted by the user could be transformed toLowerCase() Gift planet/Empire requires lowercase addresses #117
Transform input address to lower case.
I fixed the format issue and implemented your two ideas. Planets also sort by level now. |
We can merge both this and #108, but have you both chatted to see if theres a single plugin that could emerge. OR if that cant happen differentiate them further so theyre more different? |
I added some filters to make it more useful in certain scenarios. For example: send all Spacetime Rip and Foundry to others to help him collect more silver. OR in order to send artifacts to somebody, you can send the artifacts to the nearest spacetime rip then send all Spacetime Rip which held artifacts to others. |
Still indistinguishable to me frankly. One plugin "// Easily transfer planets to others. Select start/end coordinates to filter the planets." the other "gift the planet(s) circled with level filter and area filter to your friends :)" Those are the same plugin. Perhaps by writing your descriptions you two can figure out what is different |
Like map export plugin, you can select planets by draw a area on the map.
The selected the planets will highlight with red circle.
You can remove certain planets manually before transfer to other players.