Fix wrong path check in ImageLoaderMachO #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug in `strncmp(installPath, "/usr/libexec/oah/Shims", 9)` - the size argument passed seems to be copied from a previous call and results in an incorrect path check as here only the `"/usr/libe"` prefix will be checked. Please note that with my proposed change any directory path that starts with `"/usr/libexec/oah/Shims"` will be matched so `"/usr/libexec/oah/ShimsSOMETHING"` would also do. I am not aware of this codebase, so maybe there should be a `"/"` at the end of this path?
|
Thank you for your contribution, but, no. This code comes from Apple; if they have fixed this bug in a newer version, we should update to that; if they haven't, we should leave the bug as is. |
|
Good point. Reported further to opensource-apple/dyld#4. EDIT: Sadly, this is not an official repo. |
|
I were much doubt Apple's going to read GitHub issues; file a Radar or whatever they call it these days if you really want this addressed. |
|
I wonder how much effort updating our |
|
One consideration: did Apple mess with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
strncmp(installPath, "/usr/libexec/oah/Shims", 9)- the size argument passed seems to be copied from a previous call and results in an incorrect path check as here only the"/usr/libe"prefix will be checked.Please note that with my proposed change any directory path that starts with
"/usr/libexec/oah/Shims"will be matched so"/usr/libexec/oah/ShimsSOMETHING"would also do.I am not aware of this codebase, so maybe there should be a
"/"at the end of this path?