Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reference parameters as children of a TypeParameter #2721

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

srawlins
Copy link
Member

Fixes #2716

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jul 19, 2021
@srawlins srawlins requested a review from devoncarew July 19, 2021 21:06
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srawlins srawlins merged commit fbf79d8 into dart-lang:master Jul 19, 2021
@srawlins srawlins deleted the fix-2716 branch July 19, 2021 22:01
@isoos
Copy link
Contributor

isoos commented Jul 30, 2021

Thanks for the fix! Any idea when this will get released?

@srawlins
Copy link
Member Author

srawlins commented Aug 2, 2021

Sorry I meant to release this ASAP. Let me release today.

@jjliu15
Copy link

jjliu15 commented Aug 5, 2021

Hi, is there an ETA on when this will get released?
Also will this automatically fix the API docs in the packages here: #2716 (comment)?

@isoos
Copy link
Contributor

isoos commented Aug 5, 2021

@jjliu15: once dartdoc gets released, pub.dev will include it in the next release of the site (at most 2 weeks, depending on other ongoing work), and the packages will get reanalyzed, the documentation will get recreated.

@simolus3
Copy link
Contributor

Has this been released? I'm still getting this error with the latest Dart dev (2.15.0-24.0.dev (dev)), as well as 2.14.0-377.7.beta (beta) . 2.13.4 (stable) is the only channel where I'm able to run dartdoc without it crashing.

I also still get this error on one of my packages uploaded today.

@isoos
Copy link
Contributor

isoos commented Aug 20, 2021

@simolus3: I think this has been release, but your exception is a new/different one, filed #2755 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression for dartdoc 0.45.0 -> 1.0.0: protobuf version 2.0.0 fails
5 participants