Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, cleanup, and simplify CSS #3302

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 14, 2023

  • Use same search icon on both top nav and sidenav search bars (rather than pulling one from a website)
  • Use a local SVG (from Material Symbols) for search icon
  • Remove now unused search PNG
  • Remove unnecessary padding causing horizontal scrollbar on offcanvas sidenav menu
  • Remove various unused and debugging styles
  • Adjust some formatting for easier reading of theme variables
  • Remove unnecessary pixel specifiers
  • Use shorthand margin and padding syntax where possible

@parlough parlough changed the title Cleanup and simplify CSS Fix, cleanup, and simplify CSS Jan 15, 2023
@parlough parlough marked this pull request as ready for review January 16, 2023 00:15
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running through all of these!

@srawlins srawlins merged commit ed56883 into dart-lang:master Jan 17, 2023
@parlough parlough deleted the misc/simplify-css branch January 17, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants