New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeImplementing.directInterfaces private. #3555

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:private-direct-interfaces

Oct 26, 2023

Member

srawlins commented Oct 26, 2023

Also:

Delete some redundant asserts.
Change publicInterfaces from being a sync generator which are slow.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Make TypeImplementing.directInterfaces private.

cd1a3d6

srawlins requested a review from keertip

October 26, 2023 18:24

keertip approved these changes

View reviewed changes

srawlins merged commit 97ae9fe into dart-lang:main

9 checks passed

srawlins deleted the private-direct-interfaces branch

October 26, 2023 20:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet