Rename Library.allClasses; tidy other collections #3747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tidyings to prepare for a bigger Library change I'm working on:
allClasses
toclassesAndExceptions
. Every time I came acrossLibrary.allClasses
and, for example,Library.mixins
, I've thought, "why all classes?" It just turns out that it is classes-that-don't-subclass-Error-orException, and classes-that-do. Having the shared combination is still useful; I just renamed it.Library.typeSystem
over toElementType
, since it is only ever used over there.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.