Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Library.allClasses; tidy other collections #3747

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

srawlins
Copy link
Member

A few tidyings to prepare for a bigger Library change I'm working on:

  • Move all of the library collections (declared in TopLevelContainer) to one region in the file.
  • Extract out common code, since they're all defined almost the same way.
  • Rename allClasses to classesAndExceptions. Every time I came across Library.allClasses and, for example, Library.mixins, I've thought, "why all classes?" It just turns out that it is classes-that-don't-subclass-Error-orException, and classes-that-do. Having the shared combination is still useful; I just renamed it.
  • Move Library.typeSystem over to ElementType, since it is only ever used over there.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from kallentu April 15, 2024 14:30
@srawlins srawlins merged commit 46947ba into dart-lang:main Apr 16, 2024
9 checks passed
@srawlins srawlins deleted the rename-allClasses branch April 16, 2024 14:13
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 18, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/f339b09..592694e):
  592694e0  2024-04-18  Sam Rawlins  Remove redundant ModelElement.filePath implementations (dart-lang/dartdoc#3751)
  46947ba6  2024-04-16  Sam Rawlins  Rename Library.allClasses; tidy other collections (dart-lang/dartdoc#3747)
  820505ee  2024-04-15  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.2 to 1.6.4 (dart-lang/dartdoc#3749)

usage (https://github.com/dart-lang/usage/compare/09cab89..2847cdb):
  2847cdb  2024-04-17  Kevin Moore  Readme: fix status badge (dart-archive/usage#204)

webdev (https://github.com/dart-lang/webdev/compare/7d0d2d4..3a10b76):
  3a10b76f  2024-04-17  Elliott Brooks  Update DDS dependency to ^4.1.0 (dart-lang/webdev#2411)
  f73fe1ce  2024-04-17  Elliott Brooks  Update DDS to ^4.0.0 (dart-lang/webdev#2409)
  cfd5a6b9  2024-04-16  Elliott Brooks  Indicate whether an app is a Flutter app via the app ID (dart-lang/webdev#2406)

Change-Id: I4230dad426a23efb84d959fd9dccb78388c3f501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363483
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants