Split existing CSS styles into multiple scss partials #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this PR doesn't change any of the styles themselves, some ordering might have changed in the compiled file, affecting specificity. So I'll spot check this some more and would appreciate a second pair of eyes :) Edit: Looks good to me now. Feel free to review when ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change the styles at all or start to take advantage of sass features for the styles themselves. It just splits the existing styles into multiple scss partials and includes them in the root
web/styles/styles.scssfile. This will help keep related styles together, as was already attempted with inline comments before some parts of the original file.