Skip to content

Commit

Permalink
Reliably find unused port to start extension backend http service on (#…
Browse files Browse the repository at this point in the history
…1451)

We start extension backend http server with port 0, which creates flakes
in flutter web tests. Find an unused port instead.

Closes: #1450
  • Loading branch information
Anna Gringauze authored Nov 29, 2021
1 parent bd399e1 commit 8033d67
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
flutter tools and webdev.

- Fix chrome detection in iPhone emulation mode in chrome or edge browsers.
- Reliably find unused port for extension backend http service.

## 11.4.0

Expand Down
3 changes: 1 addition & 2 deletions dwds/lib/src/servers/extension_backend.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import 'dart:async';
import 'dart:io';

import 'package:async/async.dart';
import 'package:http_multi_server/http_multi_server.dart';
import 'package:logging/logging.dart';
import 'package:shelf/shelf.dart';

Expand Down Expand Up @@ -54,7 +53,7 @@ class ExtensionBackend {
}
return Response.notFound('');
}).add(_socketHandler.handler);
var server = await HttpMultiServer.bind(hostname, 0);
var server = await startHttpServer(hostname);
serveHttpRequests(server, cascade.handler, (e, s) {
_logger.warning('Error serving requests', e);
emitEvent(DwdsEvent.httpRequestException('ExtensionBackend', '$e:$s'));
Expand Down

0 comments on commit 8033d67

Please sign in to comment.