Use window.navigator.vendor to detect chromium-based browsers #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 11:14
Previously we used `window.navigator.userAgent` to detect if the browser is chromium-based, but that detection fails during iphone simulation in chrome or egde. Change the detection to use `window.navigator.vendor` instead. CLoses: flutter/flutter#92567
nshahan
approved these changes
Nov 18, 2021
grouma
approved these changes
Nov 18, 2021
Yes to both questions. I run this on my windows machine with edge and chrome with various emulators to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
window.navigator.userAgentto detect if thebrowser is chromium-based, but that detection fails during iphone
simulation in chrome or egde.
Change the detection to use
window.navigator.vendorinstead.Closes: flutter/flutter#92567