Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable frontend_server_client_test cases #2327

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Re-enable frontend_server_client_test cases #2327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e82446c
Re-enable frontend_server_client tests
elliette Jan 2, 2024
185278b
Merge branch 'master' into issues-2315
elliette Jan 2, 2024
afb055f
Merge branch 'master' into issues-2315
elliette Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions frontend_server_client/test/frontend_sever_client_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ String get message => p.join('hello', 'world');

expect(await stdoutLines.next, p.join('goodbye', 'world'));
expect(await process.exitCode, 0);
// TODO(https://github.com/dart-lang/webdev/issues/2315): Fix and re-enable.
}, skip: true);
});

test('can handle compile errors and reload fixes', () async {
var entrypoint = p.join(packageRoot, 'bin', 'main.dart');
Expand Down Expand Up @@ -175,8 +174,7 @@ String get message => p.join('hello', 'world');

expect(await stdoutLines.next, p.join('goodbye', 'world'));
expect(await process.exitCode, 0);
// TODO(https://github.com/dart-lang/webdev/issues/2315): Fix and re-enable.
}, skip: true);
});

test('can compile and recompile a dartdevc app', () async {
var entrypoint =
Expand Down
Loading