feat: remove insight API (#351)

Co-authored-by: Alex Werner <[email protected]> Co-authored-by: Anton Suprunchuk <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
dashevo · Apr 21, 2021 · 132f4d3 · 132f4d3
1 parent 20d8ea9
commit 132f4d3
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 1,010 deletions.
diff --git a/lib/config/index.js b/lib/config/index.js
@@ -1,5 +1,4 @@
 const OPTIONS = {
-  INSIGHT_URI: 'INSIGHT_URI',
   LIVENET: 'LIVENET',
   API_JSON_RPC_PORT: 'API_JSON_RPC_PORT',
   API_GRPC_PORT: 'API_GRPC_PORT',
@@ -22,7 +21,6 @@ const OPTIONS = {
 
 const DEFAULT_CONFIG = {};
 
-DEFAULT_CONFIG[OPTIONS.INSIGHT_URI] = 'http://127.0.0.1:3001/insight-api';
 DEFAULT_CONFIG[OPTIONS.LIVENET] = false;
 DEFAULT_CONFIG[OPTIONS.API_JSON_RPC_PORT] = 2501;
 DEFAULT_CONFIG[OPTIONS.API_GRPC_PORT] = 2500;
@@ -54,7 +52,6 @@ Object
 const config = Object.assign({}, DEFAULT_CONFIG, envConfig);
 
 module.exports = {
-  insightUri: config[OPTIONS.INSIGHT_URI],
   livenet: Boolean(config[OPTIONS.LIVENET]),
   rpcServer: {
     port: parseInt(config[OPTIONS.API_JSON_RPC_PORT], 10),

diff --git a/lib/config/validator.js b/lib/config/validator.js
@@ -38,7 +38,6 @@ function validatePort(port, parameterName) {
  */
 function validateConfig(config) {
   const validationResults = [];
-  validationResults.push(validateHost(config.insightUri, 'INSIGHT_URI'));
   validationResults.push(validateHost(config.dashcore.p2p.host, 'DASHCORE_P2P_HOST'));
   validationResults.push(validatePort(config.dashcore.p2p.port, 'DASHCORE_P2P_PORT'));
   validationResults.push(validateHost(config.dashcore.rpc.host, 'DASHCORE_RPC_HOST'));

diff --git a/lib/externalApis/insight/index.js b/lib/externalApis/insight/index.js
diff --git a/lib/grpcServer/handlers/core/coreHandlersFactory.js b/lib/grpcServer/handlers/core/coreHandlersFactory.js
@@ -48,12 +48,11 @@ const broadcastTransactionHandlerFactory = require(
 );
 
 /**
- * @param {InsightAPI} insightAPI
  * @param {CoreRpcClient} coreRPCClient
  * @param {boolean} isProductionEnvironment
  * @returns {Object<string, function>}
  */
-function coreHandlersFactory(insightAPI, coreRPCClient, isProductionEnvironment) {
+function coreHandlersFactory(coreRPCClient, isProductionEnvironment) {
   const wrapInErrorHandler = wrapInErrorHandlerFactory(log, isProductionEnvironment);
 
   // getBlock

diff --git a/package-lock.json b/package-lock.json
diff --git a/scripts/api.js b/scripts/api.js
@@ -27,7 +27,6 @@ const { validateConfig } = require('../lib/config/validator');
 const log = require('../lib/log');
 const rpcServer = require('../lib/rpcServer/server');
 const DriveClient = require('../lib/externalApis/drive/DriveClient');
-const insightAPI = require('../lib/externalApis/insight');
 const dashCoreRpcClient = require('../lib/externalApis/dashcore/rpc');
 const BlockchainListener = require('../lib/externalApis/tenderdash/BlockchainListener');
 const DriveStateRepository = require('../lib/dpp/DriveStateRepository');
@@ -102,7 +101,6 @@ async function main() {
   log.info('Starting GRPC server');
 
   const coreHandlers = coreHandlersFactory(
-    insightAPI,
     dashCoreRpcClient,
     isProductionEnvironment,
   );

diff --git a/test/mocks/config.js b/test/mocks/config.js
@@ -1,7 +1,6 @@
 module.exports = {
   getConfigFixture() {
     return {
-      insightUri: '123',
       dashcore: {
         p2p: {
           host: '123',