Speedup init of ReadParquetPyarrowFS
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Feb 29, 2024
| @@ -2867,7 +2867,7 @@ def are_co_aligned(*exprs, allow_broadcast=True): | |||
| ancestors = [set(non_blockwise_ancestors(e)) for e in exprs] | |||
| unique_ancestors = { | |||
| # Account for column projection within IO expressions | |||
| _tokenize_partial(item, ["columns", "_series"]) | |||
| _tokenize_partial(item, ["columns", "_series", "_dataset_info_cache"]) | |||
There was a problem hiding this comment.
See #907 for the root cause discussion. What I'm doing here is a pretty brittle patch imo
phofl
approved these changes
Feb 29, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a couple of fixes to the
ReadParquetPyarrowFSexpr that speed up the initial kick off significantly. On the TPCH 1000 scale datasets for Q1 creating the query and optimizing it initially took 10-11s on my machine (with me sitting in europe and the dataset in us-east-2). With these fixes, we're down to 1-2s which is on par with the fsspec implementation.