Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataset Description to the Shares View #1025

Closed
TejasRGitHub opened this issue Jan 31, 2024 · 1 comment
Closed

Add Dataset Description to the Shares View #1025

TejasRGitHub opened this issue Jan 31, 2024 · 1 comment

Comments

@TejasRGitHub
Copy link
Contributor

Is your idea related to a problem? Please describe.
Dataset description can contains critical information about the dataset and how to use it , some specific instructions/processes to follow while creating a share or instructions to follow to get the share approved,etc.

When a share is created for the dataset, the share view doesn't show the dataset description.

Thus, if any instructions were written for dataset approval, they won't be visible to the dataset requester

Describe the solution you'd like

On the shares view, create a dataset description field and show the dataset description

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

TejasRGitHub added a commit to TejasRGitHub/aws-dataall that referenced this issue Jan 31, 2024
TejasRGitHub added a commit to TejasRGitHub/aws-dataall that referenced this issue Feb 1, 2024
dlpzx pushed a commit that referenced this issue Feb 2, 2024
### Feature or Bugfix
- Feature


### Detail

As described by the problem in this GH issue -
#1025 . This will add
dataset description on the shares UI page.

### Testing 

1. Created a share for a dataset 
2. Shares Page now contains the dataset description in the  UI 

### Relates
- #1025

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)? No
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization? No
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features? No
  - Do you use a standard proven implementations?
- Are the used keys controlled by the customer? Where are they stored?
No
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@dlpzx
Copy link
Contributor

dlpzx commented Feb 5, 2024

Completed

@dlpzx dlpzx closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants